Skip to content
This repository was archived by the owner on Aug 20, 2020. It is now read-only.

invoke the API callback with a mocked response upon Error #6

Merged

Conversation

cantremember
Copy link
Contributor

@cantremember cantremember commented Sep 28, 2016

fixes #5 -- using the 'patch' release strategy. i suggest that you clone the issue if the CPS strategy is more desirable in the long-run, since it suggests a 'major' release

the 'patch' strategy was taken to minimize impact and maximize upradeability within the SendGrid Node.js suite of packages.

given an emitted new Error('MESSAGE'), the response Object passed to the callback will include

{
  statusCode: 500,
  body: {
    message: 'MESSAGE',
    name: 'Error',
    stack: 'Error: MESSAGE\n...',
  },
  headers: {},
}

@thinkingserious
Copy link
Contributor

Thanks for the pull request and detailed issue report!

Could you please sign our CLA so we can get this merged? Thanks!

@cantremember
Copy link
Contributor Author

i have sent a signed copy of your CLA to [email protected]

i'm glad to be of help 😌

@cantremember
Copy link
Contributor Author

hello, @thinkingserious . we would like to know what an ETA would be on the release of this patch. all indications are that i have provided you with the CLA information that you requested

@thinkingserious
Copy link
Contributor

Hello @cantremember,

Unfortunately, I'm unable to give you a precise ETA as we operate from a dynamically prioritized backlog. That said, issues that have a signed CLA are given an extra priority bump, so I don't expect more than a week or two to pass before we merge.

Additional votes on this issue will help bump it's priority.

Thanks!

@cantremember
Copy link
Contributor Author

i believe i can only vote once 👍

@firebait
Copy link

firebait commented Oct 5, 2016

👍

@thinkingserious
Copy link
Contributor

Thanks for the vote @firebait!

@thinkingserious thinkingserious merged commit 2901b0d into sendgrid:master Oct 12, 2016
@thinkingserious
Copy link
Contributor

@cantremember,

Thanks again for your contribution!

When you get a moment, please fill out this form so we can send you some swag :)

thinkingserious added a commit that referenced this pull request Oct 12, 2016
@cantremember cantremember deleted the issue_5_error_response branch October 17, 2016 19:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invoke the API callback upon Error
3 participants