Skip to content

fix: Allow for multiple values for a parameter #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2017
Merged

fix: Allow for multiple values for a parameter #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ruby_http_client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ def add_version(url = nil)
# - The url string with the query parameters appended
#
def build_query_params(url, query_params)
params = query_params.map { |key, value| "#{key}=#{value}" }.join('&')
params = URI.encode_www_form(query_params)
url.concat("?#{params}")
end

Expand Down
4 changes: 2 additions & 2 deletions test/test_ruby_http_client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,9 @@ def test_add_version

def test_build_query_params
url = ''
query_params = { 'limit' => 100, 'offset' => 0 }
query_params = { 'limit' => 100, 'offset' => 0, 'categories' => ['category1', 'category2'] }
url = @client.build_query_params(url, query_params)
assert_equal('?limit=100&offset=0', url)
assert_equal('?limit=100&offset=0&categories=category1&categories=category2', url)
end

def test_build_url
Expand Down