Skip to content

feat: add SendGridMessage deserialization #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2021
Merged

feat: add SendGridMessage deserialization #1115

merged 1 commit into from
May 28, 2021

Conversation

jlawcordova
Copy link
Contributor

Fixes #1104

Add a static method Deserialize to SendGrid.Helpers.Mail.SendGridMessage which recreates a SendgridMessage instance from a JSON object.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label May 28, 2021
JenniferMah
JenniferMah approved these changes May 28, 2021
View reviewed changes
Copy link
Contributor

@JenniferMah JenniferMah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @jlawcordova!

@JenniferMah JenniferMah merged commit 2f3ca52 into sendgrid:main May 28, 2021
@jlawcordova jlawcordova deleted the deserialize-sendgridmessage branch May 29, 2021 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@JenniferMah JenniferMah JenniferMah approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deserialization of SendGridMessage
3 participants
@jlawcordova @JenniferMah @thinkingserious