Code simplification #246
Merged
Code simplification #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will sign CLA soon:) |
thinkingserious
added
type: community enhancement
|
Any update on the CLA? Is there anything I can do to help? |
|
@thinkingserious Sorry I was on vacation. I will sign it tomorrow. |
|
Awesome, thanks! |
|
I going to rebase,resolve conflicts and update PR |
|
Thanks @dubrovkinmaxim! |
|
Hi @dubrovkinmaxim, This ticket finally came up to the top of my list. Could you please fix the conflicts so I can test and marge? Thanks! |
…he used in sender name
# Conflicts: # SendGrid/Example/Example.cs # SendGrid/SendGrid/Helpers/Mail/Mail.cs # SendGrid/SendGrid/SendGrid.csproj # SendGrid/UnitTest/UnitTest.cs
|
Thanks! |
|
@thinkingserious you are welcome :) |
gabrielkrell
pushed a commit
to gabrielkrell/sendgrid-csharp
that referenced
this pull request
Aug 2, 2017
Typo 'user' for 'usr'
gabrielkrell
pushed a commit
to gabrielkrell/sendgrid-csharp
that referenced
this pull request
Aug 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using auto properties to simplify code.
Data transfer objects were extracted to separated files.