Update serializer settings to include default values #273

[owre]

Changed json serializer settings to include default values to fix issue #273
The default implementation removes the enable flags from tracking settings if set to false. Resulting in:
The click_tracking(etc) enable parameter is required.

[thinkingserious]

Awesome!

Could you please sign our CLA to get this merged? https://github.com/sendgrid/sendgrid-csharp/blob/master/CONTRIBUTING.md#cla

Thanks!

[owre]

I have signed the CLA and sent it to dx@
Cheers

[thinkingserious]

I will need to give this one some more thought.

The failing TestHelloEmail test happens because your change allows "send_at":0 to be a part of the returned JSON object because the default value for a long is zero. We need to ignore unset values, but in C# all variables are initialized.

I'm thinking we need to instead build the object piece by piece and then deserialize that object vs trying to deserialize the entire Mail object and figuring out which values to ignore properly.

[owre]

How about making it nullable? That way it wont be included.

[thinkingserious]

I was thinking about trying this: https://msdn.microsoft.com/en-us/library/53b8022e(v=vs.110).aspx

[thinkingserious]

I like the nullable idea also.

[owre]

Good idea http://www.newtonsoft.com/json/help/html/conditionalproperties.htm

I think a nullable property would be easier. Is it any more property that should not be serialized with its default value?

[thinkingserious]

Generally, if you don't set a value, then it should not show up.

[thinkingserious]

Seems like if we go the nullable route, we need to initialize the values to null. Looking at the failed test, it looks like we still get "send_at":0

[owre]

I missed to make sendAt in mail nullable. Fixed :)

[thinkingserious]

Nice work! I'm hoping to have some time to review today.

[thinkingserious]

@owre,

I just put in a pull request on your fork that adds in the rest of the nullable fixes, plus an additional unit test.

[thinkingserious]

#293

[thinkingserious]

@owre,

Please shoot us an email to [email protected] with your mailing address and T-shirt size so we can send you a token of our appreciation.

[owre]

Thank you very much! :)