Issue #358: SendGridClient.SendEmailAsync now throws original exception #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f swallowing and reporting https status 200.
thinkingserious
added
the
status: code review request
|
|
|
Hello @ottomatic, |
This was referenced Apr 13, 2017
This was referenced May 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SendGridClient.SendEmailAsync now throws original exception instead of swallowing and reporting http status 200.
In order to make the client unit testable for underlying exceptions thrown when making http requests, there is now a new constructor overload which takes an HttpClient object as one of the parameters.