attachments - Support for InputStream?

[ChickenSniper]

In version 3, any plans to update attachments to support InputStream instead of File? Our system creates PDF on the fly, never saving to file system. Works in your version 2...need this to upgrade.

Thanks!

[thinkingserious]

Hello @ChickenSniper,

Well, now we do :)

I'll add this to our backlog so we can add this to the Mail Helper.

Meanwhile, the setContent function only needs the content to be base64 encoded. Looks like this function will get you there.

[dmitraver]

Hi!

Is it still relevant? I can help with this if its still needed.

[ChickenSniper]

@dmitraver It would definitely be helpful...I'm using this library in my scala application, so streams are very important to us for performance...

[thinkingserious]

@dmitraver,

Thanks for offering to help!

Please take a moment to sign our CLA so that I can merge your solution when ready: https://github.com/sendgrid/sendgrid-java/blob/master/CONTRIBUTING.md#cla

[dmitraver]

@thinkingserious cool, then I will sign a CLA and make a PR in a couple of days

[dmitraver]

I've checked the code and it looks like I just need to add a new method that accepts InputStream as a parameter and then calls setContent which doesn't sound really helpful. I haven't found any methods that accept plain Files in current version. Has I missed something?

[thinkingserious]

@dmitraver,

Here is how it was done previously:

sendgrid-java/src/main/java/com/sendgrid/SendGrid.java

Line 120 in b64988f

if (email.getAttachments().size() > 0) {

I hope that helps.

[jmayday]

When I look at Attachments.Builder, I see that it calls toByteArray at some point.

    /**
     * Creates a newly allocated byte array. Its size is the current
     * size of this output stream and the valid contents of the buffer
     * have been copied into it.
     *
     * @return  the current contents of this output stream, as a byte array.
     * @see     java.io.ByteArrayOutputStream#size()
     */
    public synchronized byte[] toByteArray() {
        return Arrays.copyOf(buf, count);
    }

Does then the solution scale? Are there better options for sending attachemnts? If there are 10 request at sime time, each sending 10mb attachment file, then 100mb of RAM will be used?