Skip to content

Send a Single Email to a Single Recipient #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thinkingserious opened this issue Oct 6, 2016 · 3 comments
Closed

Send a Single Email to a Single Recipient #150

thinkingserious opened this issue Oct 6, 2016 · 3 comments
Labels
status: work in progress Twilio or the community is in the process of implementing type: community enhancement feature request not on Twilio's roadmap

Comments

@thinkingserious
Copy link
Contributor

Acceptance Criteria:

  • A email object that represents the response body payload
  • A mail object that handles sending email objects, data validation and error handling

Reference:

@thinkingserious thinkingserious added status: help wanted requesting help from the community type: task labels Oct 6, 2016
@stangles
Copy link

stangles commented Oct 8, 2016

Hi, I would like to work on this issue. I took a peek at the contribution guidelines and will send along a CLA soon.

My understanding of the task: expose a way for a user of sendgrid-java to call some publicly exposed method on a Mail object. This method encapsulates the work of validating the email object, creating the request body, sending the request, parsing the response and handling errors.

Questions I have on the acceptance criteria:

Additionally, I was wondering if the sendgrid-java library should necessarily treat this issue, #151 and #152 as separate issues. It would seem to me that you could have one or two publicly available methods that would accept a List of Email objects for the to field, which would take care of this and #151 simultaneously.

@thinkingserious thinkingserious added status: work in progress Twilio or the community is in the process of implementing and removed status: help wanted requesting help from the community labels Oct 10, 2016
@thinkingserious
Copy link
Contributor Author

Hello @stangles,

Thanks for the detailed questions, very helpful!

Yes, the Mail and Email objects already exist. This is a refactor.

The validation should be based upon this swagger (OAI) file. Ideally, the object should load that file and load the validations in the constructor.

You are correct, issue #150, #151 and #152 should be considered together for the initial design.

Please let me know if you have any further questions.

With Best Regards,

Elmer

@thinkingserious
Copy link
Contributor Author

Implementation will be tracked in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: work in progress Twilio or the community is in the process of implementing type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

No branches or pull requests

2 participants