Skip to content

Fix #404 Add ability to impersonate subusers #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2019
Merged

Fix #404 Add ability to impersonate subusers #495

merged 1 commit into from
May 10, 2019

Conversation

Rohit-T
Copy link
Contributor

@Rohit-T Rohit-T commented Oct 12, 2018 •
edited
Loading

SendGrid API has a feature that allows a parent account to impersonate
subusers by including an HTTP header "on-behalf-of" in the API request.
This commit enables users to use impersonation.

Fixes

Fixes #404

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • This PR allows users to impersonate subusers

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@Rohit-T
Add ability to impersonate subusers
ba77a01 
SendGrid API has a feature that allows a parent account to impersonate
subusers by including an HTTP header "on-behalf-of" in the API request.
This commit enables users to use impersonation.
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 12, 2018
@devchas devchas added difficulty: medium fix is medium in difficulty hacktoberfest type: twilio enhancement feature request on Twilio's roadmap labels Oct 17, 2018
@thinkingserious thinkingserious merged commit fa601b1 into sendgrid:master May 10, 2019
@thinkingserious
Copy link
Contributor

Hello @Rohit-T,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the ability to impersonate a subuser
3 participants
@Rohit-T @thinkingserious @devchas