Skip to content

Python 3.7 Support? #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
noqcks opened this issue Oct 18, 2018 · 3 comments
Closed

Python 3.7 Support? #691

noqcks opened this issue Oct 18, 2018 · 3 comments
Labels
difficulty: unknown or n/a fix is unknown in difficulty status: waiting for feedback waiting for feedback from the submitter type: question question directed at the library

Comments

@noqcks
Copy link

noqcks commented Oct 18, 2018

Is Python 3.7 supported by this library? (v5.6.0)

If not, is there any ETA on when support will be included?

@hugovk
Copy link
Contributor

hugovk commented Oct 19, 2018

I don't know but I can tell you:

I created PR #615 to add Python 3.7 to the master branch (which has version 5.6.0):

version_info = (5, 6, 0)

But I was asked to move it instead to the v4 branch (which has version 5.4.1):

version_info = (5, 4, 1)

So I closed #615 and made PR #637 instead which was merged.

@thinkingserious thinkingserious added type: question question directed at the library difficulty: unknown or n/a fix is unknown in difficulty status: waiting for feedback waiting for feedback from the submitter labels Nov 18, 2018
@thinkingserious
Copy link
Contributor

Hello @noqcks,

We are working on a new v4 release of this SDK which will specifically included support for 3.7. That said, @hugovk was able to show 3.7 support in this particular library. Please let us know if you run into any trouble.

With Best Regards,

Elmer

@kevin-brown
Copy link
Contributor

The tests pass on the master branch (see #744), so I think it can be said that the library does in fact support Python 3.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: unknown or n/a fix is unknown in difficulty status: waiting for feedback waiting for feedback from the submitter type: question question directed at the library
Projects
None yet
Development

No branches or pull requests

4 participants