Skip to content

Update Travis CI matrix for testing #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

Update Travis CI matrix for testing #744

wants to merge 9 commits into from

Conversation

kevin-brown
Copy link
Contributor

@kevin-brown kevin-brown commented Dec 24, 2018 •
edited
Loading

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Run on Python 3.7
  • Switch to using Tox to execute tests
  • Switch to tox-travis for less repeated configuration

@kevin-brown
Test on Python 3.7
224552c 
This is only supported on Xenial builds, so let's see if anything depended on Trusty builds.
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Dec 24, 2018
@SendGridDX
Copy link

SendGridDX commented Dec 24, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kevin-brown
Python 2.6 must run on Trusty
447cf5d 
The rest appear to be supported out of the box on Xenial.
@codecov
Copy link

codecov bot commented Dec 24, 2018

Codecov Report

Merging #744 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #744   +/-   ##
=======================================
  Coverage   85.04%   85.04%           
=======================================
  Files          35       35           
  Lines        1157     1157           
  Branches      172      172           
=======================================
  Hits          984      984           
  Misses         90       90           
  Partials       83       83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 265b984...447cf5d. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 24, 2018 •
edited
Loading

Codecov Report

Merging #744 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #744   +/-   ##
=======================================
  Coverage   85.04%   85.04%           
=======================================
  Files          35       35           
  Lines        1157     1157           
  Branches      172      172           
=======================================
  Hits          984      984           
  Misses         90       90           
  Partials       83       83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 265b984...be7db90. Read the comment docs.

@kevin-brown
Run Travis CI tests using Tox
8dc6500
@kevin-brown
Fix Python 2.6 testing command
6cc5374
@kevin-brown
Fix Python 2 testing requirements
fced756 
Also, pytest is required despite the fact that it's not being used as the test runner?
@kevin-brown
Add Python 3.7 to Trove classifiers
39494fd
@kevin-brown
Remove signs of Python 3.2 and Python 3.3
4c4cc22 
This removes Python 3.2 and Python 3.3 from the Trove classifiers for the project, so they no longer show up on PyPI as supported versions. This matches the versions tested in Travis CI as well as the versions stated in the README.

This removes the requirement handling for Python 3.0 and Python 3.1, which haven't been supported for quite some time.

This also blocks installation of the package of the older versions of Python that are no longer supported, so Pip won't even attempt to install it.
@kevin-brown
unittest2 shouldn't be required
caedb09 
This is requird in order to test the package, but it should not be required in order to execute the package itself.
@kevin-brown
Add Python 3.7 to README
be7db90
@kevin-brown kevin-brown changed the title [WIP] Update Travis CI matrix for testing Update Travis CI matrix for testing Dec 24, 2018
@kevin-brown kevin-brown mentioned this pull request Dec 24, 2018
Closed
misterdorm
misterdorm requested changes Dec 26, 2018
View reviewed changes
Copy link
Contributor

@misterdorm misterdorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase against the v4 branch. This repo is a little different and we don't merge PRs into master. Thanks!

@kevin-brown
Copy link
Contributor Author

@misterdorm I'll rebase this branch in the future (next time I'm working on these PRs), but I have some questions about how this repo works.

  1. I see that the master branch has a version of 5.6.0 which matches the one on PyPI. Is there a plan to release from the v4 branch any time soon?
  2. If the v4 branch is the preferred PR destination, is there a reason why the default branch on this repo (and thus, the default PR destination) is set to master?

@kevin-brown
Copy link
Contributor Author

Because mumbles I've opened a new PR against the v4 branch at #750. Closing this one off...

@kevin-brown kevin-brown deleted the travis-matrix branch January 21, 2019 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misterdorm misterdorm misterdorm requested changes

Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevin-brown @SendGridDX @misterdorm @thinkingserious