Skip to content

Add test for apps.py #418 #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2017
Merged

Add test for apps.py #418 #433

merged 2 commits into from
Oct 30, 2017

Conversation

scomert
Copy link
Contributor

@scomert scomert commented Oct 24, 2017

Added tests for apps.py. Waiting review.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 24, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 24, 2017

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Oct 24, 2017

Codecov Report

Merging #433 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #433     +/-   ##
=========================================
+ Coverage   81.98%   82.08%   +0.1%     
=========================================
  Files           9        9             
  Lines         999      999             
  Branches      160      160             
=========================================
+ Hits          819      820      +1     
+ Misses         90       89      -1     
  Partials       90       90
Impacted Files Coverage Δ
sendgrid/helpers/inbound/app.py 78.26% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 873d069...3e81ffc. Read the comment docs.

@mbernier
Copy link
Contributor

@scomert Thank you for the contribution, as soon as you sign the CLA we can merge it in!

@mbernier mbernier merged commit 4d57885 into sendgrid:master Oct 30, 2017
@thinkingserious
Copy link
Contributor

Hello @scomert,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@mbernier mbernier added the difficulty: easy fix is easy in difficulty label Oct 30, 2017
@cbonoz cbonoz mentioned this pull request Nov 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants