Skip to content

Add a tutorial to deploy a simple "Hello Email" app on Heroku #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2018
Merged

Add a tutorial to deploy a simple "Hello Email" app on Heroku #443

merged 1 commit into from
Aug 16, 2018

Conversation

swapagarwal
Copy link
Contributor

See #356

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 26, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 26, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Oct 26, 2017 •
edited by codecov bot
Loading

Codecov Report

Merging #443 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #443   +/-   ##
=======================================
  Coverage   86.61%   86.61%           
=======================================
  Files          32       32           
  Lines         979      979           
  Branches      131      131           
=======================================
  Hits          848      848           
  Misses         67       67           
  Partials       64       64

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ac58c6...6d5e990. Read the comment docs.

@swapagarwal
Copy link
Contributor Author

ping

1 similar comment
@swapagarwal
Copy link
Contributor Author

ping

@swapagarwal
Copy link
Contributor Author

Not sure why travis is failing.

@mbernier
Copy link
Contributor

mbernier commented Nov 3, 2017

Travis is failing due to an unrelated issue and I believe that it is fixed in another PR - so we're not worried about it :)

@swapagarwal

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

@swapagarwal swapagarwal force-pushed the flask-heroku branch 2 times, most recently from 68f4d43 to 657207c Compare November 10, 2017 17:27
@swapagarwal
Copy link
Contributor Author

I rebased it on master, but travis is still failing. 🤔

@swapagarwal
Copy link
Contributor Author

ping

1 similar comment
@swapagarwal
Copy link
Contributor Author

ping

@thinkingserious
Copy link
Contributor

Hello @swapagarwal,

Your PR is currently on our list for review. We are processing them from oldest to newest. Unfortunately, this is taking much longer than usual due to the amazing results of Hacktoberfest. We appreciate your patience, thanks!

With Best Regards,

Elmer

@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty type: docs update documentation change not affecting the code labels Feb 27, 2018
@af4ro af4ro added status: ready for deploy code ready to be released in next deploy and removed status: code review request requesting a community code review or review from Twilio labels Aug 13, 2018
@thinkingserious thinkingserious merged commit cd31fc8 into sendgrid:master Aug 16, 2018
@thinkingserious
Copy link
Contributor

Hello @swapagarwal,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@cmccandless cmccandless mentioned this pull request Sep 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy type: docs update documentation change not affecting the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@swapagarwal @SendGridDX @codecov-io @mbernier @thinkingserious @af4ro @apigirl