Skip to content

npm test is failing on older NodeJs versions due to const declaration #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mbernier opened this issue Oct 22, 2017 · 2 comments · Fixed by #38 or #37
Closed

npm test is failing on older NodeJs versions due to const declaration #36

mbernier opened this issue Oct 22, 2017 · 2 comments · Fixed by #38 or #37
Labels
difficulty: medium fix is medium in difficulty

Comments

@mbernier
Copy link
Contributor

It seems like the older versions of node doesn't know what to do with const variables during testing in travis.

Travis reporting failures
@mbernier mbernier added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 22, 2017
@gr8shivam gr8shivam mentioned this issue Oct 22, 2017
Merged
@mgingras
Copy link
Contributor

@mbernier Looks like mocha drops support for 10.x as of their 4.0 release https://github.com/mochajs/mocha/releases . Freezing dev dependencies should keep tests passing. (Creating pr)

@mgingras mgingras mentioned this issue Oct 22, 2017
Merged
@gr8shivam
Copy link
Contributor

As the project dependencies have dropped support for older versions of Node, tests for these versions will always fail.

Created PR #37 to remove older versions of node and add newer versions of node in travis config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty
Projects
None yet
Milestone
No milestone
3 participants
@mbernier @mgingras @gr8shivam