Skip to content

fix: Update travis config node_js versions #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 22, 2017
Merged

fix: Update travis config node_js versions #37

merged 3 commits into from
Oct 22, 2017

Conversation

gr8shivam
Copy link
Contributor

@gr8shivam gr8shivam commented Oct 22, 2017

Updated travis config as the project dependencies have dropped support for older versions of Node. Thus, tests for these versions will always fail.

Also added newer versions of node to travis config.

Fixes #36

These will always fail because const is a part of ECMAScript 2015 (a.k.a. ES6 and Harmony), and is not enabled by default in Node.js 0.10 or 0.12. Also, ```'use strict';``` and ```const``` does not mix.
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 22, 2017
Since the dependencies have dropped support older Node versions, this will always fail.
@gr8shivam gr8shivam changed the title Remove Node 0.10 and 0.12 from travis config Updated travis config Oct 22, 2017
@mbernier
Copy link
Contributor

according to the node release site, this is confirmed.

@thinkingserious
Copy link
Contributor

Hello @gr8shivam,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@gr8shivam gr8shivam deleted the patch-1 branch October 22, 2017 18:23
@childish-sambino childish-sambino changed the title Updated travis config fix: Update travis config node_js versions Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm test is failing on older NodeJs versions due to const declaration
3 participants