Skip to content

docs: Added Troubleshooting.md #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 30, 2017
Merged

docs: Added Troubleshooting.md #34

merged 7 commits into from
Oct 30, 2017

Conversation

akram-rameez
Copy link
Contributor

In reference to #26, I've added a getter function to the header lib, which could be used by the developer, by console.log({headers: headers.get()})

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 21, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 21, 2017

CLA assistant check
All committers have signed the CLA.

@akram-rameez
Copy link
Contributor Author

This could also be added on to sendgrid-nodejs mail class.

@akram-rameez
Copy link
Contributor Author

I hadn't seen noticed jsonString() functionality and initially taken reference from the python sdk. Nonetheless, I have modified it so that the new doc (and comments) both have adequate information.

@akram-rameez
Copy link
Contributor Author

Hey guys, any idea why is build failing? It passes for the more recent version and rejects legacy versions.

@mbernier
Copy link
Contributor

@akram-rameez You may have to merge master again - I believe that we removed the older versions from travis.yml, which should solve the build issue.

@akram-rameez akram-rameez changed the title Getter function to print header Added Troubleshooting.md Oct 25, 2017
@mbernier mbernier added difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 30, 2017
@mbernier mbernier merged commit 587d41b into sendgrid:master Oct 30, 2017
@thinkingserious
Copy link
Contributor

Hello @akram-rameez,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@mbernier
Copy link
Contributor

@akram-rameez
If you are interested, we would love the opportunity to talk to you about Hacktoberfest and our API libraries.

Our agenda would be: Explore what you liked and is there anything we can do to improve?

You can grab a time on my calendar that works for you and we can have a chat on Google Hangout or Skype. If you prefer, you can email me using my GitHub username at my company’s domain.

Thank you so much,

Matt Bernier - @mbernier - SendGrid Developer Experience Product Manager
Elmer Thomas - @thinkingserious - SendGrid Developer Experience Engineer
@sendgrid

@childish-sambino childish-sambino changed the title Added Troubleshooting.md docs: Added Troubleshooting.md Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants