Skip to content

test: Add a unittest to check the license.md file date range #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2017
Merged

test: Add a unittest to check the license.md file date range #62

merged 1 commit into from
Oct 30, 2017

Conversation

lvarayut
Copy link
Contributor

@lvarayut lvarayut commented Oct 28, 2017 •
edited
Loading

Fixes #57

Note: the test will fail because the LICENSE file contains the end of year 2016 instead of 2017

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 28, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 28, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 29, 2017
@mbernier
Copy link
Contributor

Neat! Thank you!!

@mbernier mbernier merged commit 29a7fb0 into sendgrid:master Oct 30, 2017
@thinkingserious
Copy link
Contributor

Hello @lvarayut,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@mauricetmeyer mauricetmeyer mentioned this pull request Oct 11, 2018
Closed
6 tasks
@childish-sambino childish-sambino changed the title Add a unittest to check the license.md file date range test: Add a unittest to check the license.md file date range Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a unittest to check the license.md file date range
4 participants
@lvarayut @SendGridDX @mbernier @thinkingserious