Skip to content

docs: Correct *.md files using Grammarly #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2020

Conversation

myzeprog
Copy link
Contributor

@myzeprog myzeprog commented Oct 5, 2018

Fixes #69

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Correcting *.md files using Grammarly

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 5, 2018
@myzeprog myzeprog force-pushed the fix-issue-69 branch 4 times, most recently from ca02694 to 586e9ec Compare October 7, 2018 18:22
@misterdorm misterdorm added status: work in progress Twilio or the community is in the process of implementing difficulty: medium fix is medium in difficulty hacktoberfest and removed status: code review request requesting a community code review or review from Twilio labels Oct 11, 2018
@misterdorm
Copy link

#75 will fix the Travis failures.

Copy link

@misterdorm misterdorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after rebasing after #75 merged.

@codecov
Copy link

codecov bot commented Oct 13, 2018

Codecov Report

❗ No coverage uploaded for pull request base (main@07ca62c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #70   +/-   ##
=======================================
  Coverage        ?   99.32%           
=======================================
  Files           ?        2           
  Lines           ?      149           
  Branches        ?        0           
=======================================
  Hits            ?      148           
  Misses          ?        1           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07ca62c...6bcb359. Read the comment docs.

@myzeprog
Copy link
Contributor Author

@misterdorm I made rebase and resolved all conflicts, Thanks

@thinkingserious thinkingserious added status: code review request requesting a community code review or review from Twilio type: docs update documentation change not affecting the code status: hacktoberfest approved and removed status: work in progress Twilio or the community is in the process of implementing labels Oct 22, 2018
@thinkingserious
Copy link
Contributor

Hello @myzeprog,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@misterdorm misterdorm added status: ready for merge code deemed fit for merge and removed status: code review request requesting a community code review or review from Twilio labels Oct 31, 2018
@childish-sambino childish-sambino removed the type: docs update documentation change not affecting the code label Jul 20, 2020
@thinkingserious thinkingserious changed the base branch from master to main July 28, 2020 14:37
@childish-sambino childish-sambino changed the title Correcting *.md files using Grammarly docs: Correct *.md files using Grammarly Aug 13, 2020
@childish-sambino childish-sambino merged commit e4e3400 into sendgrid:main Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: ready for merge code deemed fit for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run our *.md documents in this repo through the Grammer.ly service and update
4 participants