Skip to content

docs: Fix .md with Grammar.ly #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

ssiddhantsharma
Copy link
Contributor

@ssiddhantsharma ssiddhantsharma commented Oct 7, 2018

Closes #69

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Every .md file in this repo has been run through the Grammer.ly service and updated accordingly

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 7, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 7, 2018

CLA assistant check
All committers have signed the CLA.

@misterdorm misterdorm added status: work in progress Twilio or the community is in the process of implementing difficulty: medium fix is medium in difficulty hacktoberfest and removed status: code review request requesting a community code review or review from Twilio labels Oct 11, 2018
Copy link

@misterdorm misterdorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebasing after #75 is merged will fix Travis failure.

@thinkingserious thinkingserious added status: code review request requesting a community code review or review from Twilio status: hacktoberfest approved and removed status: work in progress Twilio or the community is in the process of implementing labels Oct 22, 2018
@thinkingserious
Copy link
Contributor

Hello @ssiddhantsharma,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious added the type: docs update documentation change not affecting the code label Oct 22, 2018
@thinkingserious
Copy link
Contributor

Hi @ssiddhantsharma,

Could you please resolve the merge conflicts? Thank you!

With Best Regards,

Elmer

@thinkingserious
Copy link
Contributor

Hello @ssiddhantsharma,

Thanks again for the PR!

You have earned 12 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at [email protected].

Thank you and Happy Hacktobering!

Team SendGrid

Copy link

@misterdorm misterdorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ssiddhantsharma Please rebase and address conflicts.

@misterdorm misterdorm added status: work in progress Twilio or the community is in the process of implementing and removed status: code review request requesting a community code review or review from Twilio labels Oct 31, 2018
@childish-sambino childish-sambino removed the type: docs update documentation change not affecting the code label Jul 20, 2020
@thinkingserious thinkingserious changed the base branch from master to main July 28, 2020 14:37
@childish-sambino childish-sambino changed the title #69 Fixed .md with Grammar.ly docs: Fix .md with Grammar.ly Aug 13, 2020
@childish-sambino childish-sambino merged commit 999dd10 into sendgrid:main Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: work in progress Twilio or the community is in the process of implementing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run our *.md documents in this repo through the Grammer.ly service and update
5 participants