Incompatibility with Node 12/master

[mcollina]

From our tests, this module will not work on Node 12/master, likely for the usage of some deprecated V8 APIs.

We are currently removing this from our CITGM suite: nodejs/citgm#654.

[reconbot]

Good to know, thank you

[reconbot]

A collection of different types of upgrades we need to make.

We have a lot of calls to call that now needs an AsyncResource but I have no idea where that comes from.
https://github.com/node-serialport/node-serialport/blob/7c84e525979fc7252445c07928005cb2143a4ae2/packages/bindings/src/darwin_list.cpp#L352

Here we convert a string from js to a c string, and from an object to an object and there's a new way to do that I but I'm not sure what it is.
https://github.com/node-serialport/node-serialport/blob/7c84e525979fc7252445c07928005cb2143a4ae2/packages/bindings/src/serialport.cpp#L37-L48

That might be everything!

[zbjornson]

Taking a shot at a PR now.

[indutny]

I don't think AsyncResource is absolutely necessary. You could just use v8::Local<v8::Value> Call(int argc, v8::Local<v8::Value> argv[]) const; as described in that nan API page.

Will take a look at object later.

[indutny]

Oh yikes. Didn't refresh the page since yesterday! 😉 😂 Glad that it is resolved now!

[fivdi]

I don't think AsyncResource is absolutely necessary. You could just use v8::Local<v8::Value> Call(int argc, v8::Local<v8::Value> argv[]) const; as described in that nan API page.

@indutny Are you sure AsyncResource isn't absolutely necessary? My assumption has been that AsyncResource is needed for asynchronous callbacks and that v8::Local<v8::Value> Call(int argc, v8::Local<v8::Value> argv[]) const; can only be used for synchronous callbacks. The callbacks that were modified in the PR corresponding to this issue all look like asynchronous callbacks so I think AsyncResource is needed.

[zbjornson]

This code I think actually should be updated to use AsyncResource. Without it the async context isn't propagated. I (sort of blindly) updated the syntax without adding AsyncResource. It's a simple change and an example of doing it correctly is here:

https://github.com/Automattic/node-canvas/blob/578918ffb385660aa01891349e2619d3784c2088/src/Canvas.cc#L470-L479

[indutny]

You're right, @fivdi and @zbjornson . Having AsyncResource in general should be a good idea. What I was implying is that its use wasn't necessary for making things compile again. Good feature request, though!

[reconbot]

Looking at N-API for when 6.0 gets end of lifed, but this might be a better approach nodejs/nan#836