Skip to content

Add support for specifying non-clustered index sort direction #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Add support for specifying non-clustered index sort direction #637

wants to merge 4 commits into from

Conversation

gumbarros
Copy link

This closes #636

@ckadluba
Copy link
Member

ckadluba commented Sep 29, 2025 •
edited
Loading

Thank you for the PR @gumbarros! After a first glance at the code, it looks quite good. A few tings are still to be done.

  1. There is one of more failing tests.
  2. The new config parameter also has to be read from config files (check out the code in src/Serilog.Sinks.MSSqlServer/Configuration)
  3. Add tests for the new functionality (especially in SqlTableWriter)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow configuring index direction for TimeStamp.NonClusteredIndex
2 participants
@gumbarros @ckadluba