Skip to content

Conversation

MonticolaExplorator
Copy link
Contributor

This changes modify Serilog.Sinks.File in order to generate symbols package (snupkg). Appveyor configuration is modified in order to collect the new artifact, and also to publish it both to nuget and to github release.

Fixes #194

@nblumhardt
Copy link
Member

Thanks! LGTM 👍

@nblumhardt nblumhardt merged commit 2a61b4b into serilog:dev Dec 26, 2023
auth_token:
secure: p4LpVhBKxGS5WqucHxFQ5c7C8cP74kbNB0Z8k9Oxx/PMaDQ1+ibmoexNqVU5ZlmX
artifact: /Serilog.*\.nupkg/
artifact: /Serilog.*(\.|\.s)nupkg/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI \.s? would mean the same thing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the feedback! I was so much finding my way around appveyor that I did not realize this regex coud be simplified.

@nblumhardt nblumhardt mentioned this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

snupkg not provided

3 participants