Skip to content

Support deployment bucket server side encryption #63

@sbkn

Description

@sbkn

As Serverless now can be configured to use server side encryption for a pre existing deployment bucket, can we use the same for this plugin?

Activity

HyperBrain

HyperBrain commented on Jun 29, 2017

@HyperBrain
Member

The plugin uploads the alias CF templates to the same bucket as SLS does for the base artifacts and templates. I did not test the feature yet. Can you try it and check if there are any issues with the alias uploads?
If there are any, the upload function within the alias plugin should be adapted accordingly to match the semantics found in the latest Serverless framework version.

sbkn

sbkn commented on Jun 29, 2017

@sbkn
Author

As far as I can tell the plugin does not respect the serverSideEncryption setting. So if I set deploymentBucket->serverSideEncryption to f.e. aws:kms and configure the pre-existing bucket to deny unencrypted files, the initial template will be uploaded successfully while the alias template will fail with Access Denied.

HyperBrain

HyperBrain commented on Jun 29, 2017

@HyperBrain
Member

Ok. Then this is a missing feature and the upload of the alias templates should be changed to match the semantics now used in the core framework, i.e. to support the serverSideEncryption setting.

changed the title [-]Deployment bucket server side encryption[/-] [+]Support deployment bucket server side encryption[/+] on Jun 29, 2017
added this to the 1.3.1 milestone on Jul 5, 2017
HyperBrain

HyperBrain commented on Jul 5, 2017

@HyperBrain
Member

@sbkn The feature is ready (available in the PR). Although I have still to adapt the unit tests to get the coverage up again, you can already test it. and merged to master. Please leave a feedback here, if it works as expected now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @HyperBrain@sbkn

        Issue actions

          Support deployment bucket server side encryption · Issue #63 · serverless-heaven/serverless-aws-alias