Fix for functionnames where functionname A startwith functionname B #162
+284
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.find would find wrong versionname and aliasname
…function name B - test stack updated with case that covers the issue
|
I've added commit with:
|
|
@HyperBrain pls review |
lib/stackops/apiGateway.js
Outdated
| const versionName = _.find(_.keys(versions), version => _.startsWith(version, functionName)); | ||
| const aliasName = _.find(_.keys(aliases), alias => _.startsWith(alias, functionName)); | ||
| const isExternalRef = isExternalRefAuthorizerPredicate(permission.Properties.FunctionName); | ||
| const versionName = _.find(_.keys(versions), version => _.startsWith(version, `${functionName}LambdaVersion`)); |
There was a problem hiding this comment.
this will work, but you essentially not checking for _.startsWith anymore but for string equality. Shouldn't then a simple === suffice?
May be to be more robust this should be _startsWith(version
There was a problem hiding this comment.
getFunctionVersionName and getAliasVersionName functions added to utils
There was a problem hiding this comment.
the way to retrieve the version name and the alias name is repeated multiple times. Maybe this could be move to utility functions and defined only once. e.g.
function getVersionName(versions, functionName) {
return _.find(_.keys(versions), version => _.startsWith(version, `${functionName}LambdaVersion`));
}
similar for aliasName
- getFunctionVersionName and getAliasVersionName function added to utils
aleksdikanski
approved these changes
May 10, 2019
defnotrobbie
pushed a commit
to 1stdibs/serverless-aws-alias
that referenced
this pull request
Nov 14, 2022
…or-naming-issue Fix for functionnames where functionname A startwith functionname B
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.find would find wrong versionname and aliasname
Example:
Function A: GetAccount
Function B: GetAccountByName
For function GetAccountByName the versionname and aliasname would be from the GetAccount function