Skip to content

Conversation

kcjpop
Copy link
Contributor

@kcjpop kcjpop commented Sep 28, 2017

What did you implement:

deploy:createDeploymentArtifacts was deprecated, so this PR is just to update to the new package:createDeploymentArtifacts hook. Close #126.

Reference: https://github.com/serverless/serverless/blob/cc0ada25cf5b4397c15c1d82c918f59942d0c702/lib/plugins/deploy/deploy.js#L24

How did you implement it:

How can we verify it:

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: YES

@HyperBrain
Copy link
Member

Hi @kcjpop . Thanks for the PR. This effectively closes #126 .
I will schedule the PR to be part of the 4.0.0 release, because it demands a Serverless version of 1.12 or greater and is breaking from that perspective.

@HyperBrain HyperBrain added this to the 4.0.0 milestone Sep 28, 2017
@kcjpop
Copy link
Contributor Author

kcjpop commented Sep 29, 2017

Hi @HyperBrain. Thanks for the follow-up. I updated my above comment accordingly.

@HyperBrain
Copy link
Member

Released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WARNING: Plugin ServerlessWebpack uses deprecated hook before:deploy:createDeploymentArtifact

2 participants