Skip to content

Conversation

dseeker
Copy link
Contributor

@dseeker dseeker commented Jan 25, 2020

What did you implement:

Exclude files from zip using regular expression

How did you implement it:

Added new param to configuration, create a conditional to filter the files array if param exists

How can we verify it:

add options excludeRegex: .ts to configuration
check zip file for .ts files

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

Copy link
Member

@miguel-a-calles-mba miguel-a-calles-mba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, may you please address the merge conflicts? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants