Move ts-node as optional dependency
#636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j0k3r
force-pushed
the
fix/ts-node-as-optional-dep
branch
from
0603486 to
9d8d846
Compare
That dependency must be added by the user only if they use TypeScript. An error will be throw if the dependency is not added and the serverless-webpack configuration is written in TypeScript.
j0k3r
force-pushed
the
fix/ts-node-as-optional-dep
branch
from
9d8d846 to
dd134be
Compare
miguel-a-calles-mba
approved these changes
Sep 12, 2020
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes #633
How did you implement it:
ts-nodedependency must be added by the user only if they use TypeScript.How can we verify it:
An error will be throw if the dependency is not added and the serverless-webpack configuration is written in TypeScript.
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO