Eventstate does not default the 'exclusive' field to true.

[alankm]

What happened:

Unmarshaling a workflow with an Event state that has an unspecified 'exclusive' field. The value for the field is 'false'.

What you expected to happen:

The spec states that the default value for 'exclusive' should be 'true'.

Anything else we need to know?:

If a key is missing in JSON Go will unmarshal it to the type's default value. The default value for a boolean in Go is false. To fix this you could either change the field to a pointer to a bool or write a custom json unmarshaler for the struct.

[ricardozanini]

Thanks for opening @alankm
I'll fix that ASAP. But if you have the bandwidth, please feel free to send a PR!
Many thanks!

[alankm]

What are your requirements in terms of breaking changes? I notice the release is tagged v1.0.0, which may imply that breaking changes are not acceptable.

The reason I ask is because the cleanest way to fix this would be to change the field to a pointer.

[ricardozanini]

I agree using pointers instead is a better and cleaner approach. I'd rather not break the API, but the project is reasonably new. That way I think we can tolerate this break for now and release a v1.1.0.

[alankm]

The model code looks like it was generated. Was that a one-off? If I make changes to those files will they end up being overwritten?

[ricardozanini]

Yeah, the model code is generated, but we have a script to change it. For now, is a shell script "hack". We could elaborate more to add those kinds of changes.

[iwita]

Hi @alankm ,

Do you have any testcase for this?

[ricardozanini]

@iwita also fixed in #26