first iteration - deepcopy

[spolti]

Signed-off-by: spolti [email protected]

Fixes #99

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:

Special notes for reviewers:

Additional information (if needed):

[spolti]

@davidesalerno can you please review as well?

[spolti]

It is a work in progress pull request, I've pushed to collect feedback.

[ricardozanini]

@lsytj0413, I believe the interface{} type (as being the object representation in Go) is not supported by the deepCopy methods IIRC.

@spolti, let's try to keep the generated code in zz_generated(...); this way, we avoid modifications in the non-generated code.

[lsytj0413]

@lsytj0413, I believe the interface{} type (as being the object representation in Go) is not supported by the deepCopy methods IIRC.

@spolti, let's try to keep the generated code in zz_generated(...); this way, we avoid modifications in the non-generated code.

Yep，in some scenario we can replace interface{} with concrete type（such as IntOrString），but this cannot valid with workflow.States field（the element of States field can be one of ParallelState、SwitchState and so on）

[ricardozanini]

@lsytj0413, I believe the interface{} type (as being the object representation in Go) is not supported by the deepCopy methods IIRC.
@spolti, let's try to keep the generated code in zz_generated(...); this way, we avoid modifications in the non-generated code.

Yep，in some scenario we can replace interface{} with concrete type（such as IntOrString），but this cannot valid with workflow.States field（the element of States field can be one of ParallelState、SwitchState and so on）

I believe that we can work that out with well-defined types.

I'll wait for this one to be done to release the new version.

[spolti]

I am currently trying to add the new Type as suggested, IntOrObject (based on the same approach from k8s apimachinery used for IntOrString).
Let's see how that goes.

@lsytj0413, I believe the interface{} type (as being the object representation in Go) is not supported by the deepCopy methods IIRC.
@spolti, let's try to keep the generated code in zz_generated(...); this way, we avoid modifications in the non-generated code.

Yep，in some scenario we can replace interface{} with concrete type（such as IntOrString），but this cannot valid with workflow.States field（the element of States field can be one of ParallelState、SwitchState and so on）

I believe that we can work that out with well-defined types.

I'll wait for this one to be done to release the new version.

[spolti]

Hi guys, please refer to my last commit, I got something "workable", I've added the IntOrObject custom object that allow us to have basically a object of any kind (for now, int, string and interface{}).

This first proposal exemplifies two possible ways to implement it:

First, have Integer, String and Custom fields, that we will have something like:

"time":model.IntOrObject{IntVal:(*int)(0x1400027bdb8), StrVal:(*int)(nil), ObjVal:model.Object(nil)}})

and the second option will be having only the ObjVal field, producing something like:

 "time":model.IntOrObject{ObjVal:model.MyInt{Value:48}}})

With both approach we can parse the following (tested only with arguments for now):

  - name: CheckCreditCallback
    type: callback
    action:
      functionRef:
        refName: callCreditCheckMicroservice
        arguments:
          customer: "${ .customer }"
          argsObj: {
                   "name" : "hi",
                   "age": 10
          }
          time: 48

Can be check in the failing test, the output would be:

expected: map[string]string(map[string]string{"customer":"${ .customer }"})
actual  : map[string]model.IntOrObject(map[string]model.IntOrObject{"customer":model.IntOrObject{IntVal:(*int)(nil), ObjVal:model.MyString{Value:"${ .customer }"}}, "argsObj":model.IntOrObject{IntVal:(*int)(nil), ObjVal:model.custom{Object:map[string]interface {}{"age":10, "name":"hi"}}}, "time":model.IntOrObject{IntVal:(*int)(nil), ObjVal:model.MyInt{Value:48}}})

[ricardozanini]

Seems fine, but can you take a look at the CI faiulres?

[spolti]

CI is failing on purpose, so you guys can take a look on the diference between the previous and the proposed version of the custom object.

[spolti]

about sonatype-lift, it is complaining about the deepCopy generated file, asked it to be ignored already, hopefully it will be green once it runs again.

[ricardozanini]

CI is failing on purpose, so you guys can take a look on the diference between the previous and the proposed version of the custom object.

let's wait for @lsytj0413 feedback. We can set a milestone next Monday and go ahead with the changes to the other structures.

[spolti]

@ricardozanini about the option, what option do you think better?
Planning to finish the changes tomorrow.

[spolti]

Hi guys, please refer to my last commit, I got something "workable", I've added the IntOrObject custom object that allow us to have basically a object of any kind (for now, int, string and interface{}).

This first proposal exemplifies two possible ways to implement it:

First, have Integer, String and Custom fields, that we will have something like:

"time":model.IntOrObject{IntVal:(*int)(0x1400027bdb8), StrVal:(*int)(nil), ObjVal:model.Object(nil)}})

and the second option will be having only the ObjVal field, producing something like:

 "time":model.IntOrObject{ObjVal:model.MyInt{Value:48}}})

With both approach we can parse the following (tested only with arguments for now):

  - name: CheckCreditCallback
    type: callback
    action:
      functionRef:
        refName: callCreditCheckMicroservice
        arguments:
          customer: "${ .customer }"
          argsObj: {
                   "name" : "hi",
                   "age": 10
          }
          time: 48

Can be check in the failing test, the output would be:

expected: map[string]string(map[string]string{"customer":"${ .customer }"})
actual  : map[string]model.IntOrObject(map[string]model.IntOrObject{"customer":model.IntOrObject{IntVal:(*int)(nil), ObjVal:model.MyString{Value:"${ .customer }"}}, "argsObj":model.IntOrObject{IntVal:(*int)(nil), ObjVal:model.custom{Object:map[string]interface {}{"age":10, "name":"hi"}}}, "time":model.IntOrObject{IntVal:(*int)(nil), ObjVal:model.MyInt{Value:48}}})

@lsytj0413 before review, please see this comment and share your thoughts on the best option based on the outputs.
nothing is final yet it is just a draft on how it would be.

[ricardozanini]

@ricardozanini about the option, what option do you think better? Planning to finish the changes tomorrow.

Go ahead and implementing a specific type for each use case.

[ricardozanini]

It's fine if you want to provide the latest comment from my review in a new PR.

[ricardozanini]

@lsytj0413 wanna take a final look? I'm willing to merge this one to finally release 0.8.