Skip to content

Conversation

spolti
Copy link
Member

@spolti spolti commented Feb 15, 2023

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:

Special notes for reviewers:

Additional information (if needed):

@spolti
Copy link
Member Author

spolti commented Feb 15, 2023

CI issue will be fixed by #144

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neat! Just a couple of minor things.

@ricardozanini
Copy link
Member

@spolti can you fix the WhiteSource check? The other one, I fix it in #149

@ricardozanini
Copy link
Member

@spolti can you rebase?

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things only, the rest looks pretty good. Maybe if you have the time, add a small CR and CRD yaml example.

spolti and others added 7 commits March 7, 2023 12:25
Signed-off-by: Spolti <[email protected]>
Co-authored-by: Ricardo Zanini <[email protected]>
Signed-off-by: Spolti <[email protected]>
Co-authored-by: Ricardo Zanini <[email protected]>
Signed-off-by: Spolti <[email protected]>
Co-authored-by: Ricardo Zanini <[email protected]>
Signed-off-by: Spolti <[email protected]>
Signed-off-by: Spolti <[email protected]>
@ricardozanini ricardozanini merged commit 8790952 into serverlessworkflow:main Mar 7, 2023
@spolti spolti deleted the opeIntg branch March 8, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants