Skip to content

Set behaviour clarification #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fjtirado opened this issue Dec 16, 2024 · 0 comments · Fixed by #1041
Closed

Set behaviour clarification #1040

fjtirado opened this issue Dec 16, 2024 · 0 comments · Fixed by #1041
Assignees
Labels
area: examples change: fix Something isn't working. Impacts in a minor version change.
Milestone

Comments

@fjtirado
Copy link
Collaborator

fjtirado commented Dec 16, 2024

What would you like to be added:
It is unclear if Set task should replace the output of the workflow with the object result of the set task or it should add the properties to the existing input (so the output is actually merge of the input plus the set object)

Why is this needed:
One of the examples seems to take the merge approach (otherwise the first two sets are dead code), while one of the features seems to take the replacement approach (otherwise it would have just set the shape)

After some discussion (there are different view on that) , the feature wins over the example. The example needs to be corrected and the specification should clarify the behaviour of the task.

@fjtirado fjtirado self-assigned this Dec 16, 2024
@fjtirado fjtirado changed the title Set behavior clarification Set behaviour clarification Dec 16, 2024
fjtirado added a commit to fjtirado/specification that referenced this issue Dec 16, 2024
Signed-off-by: Francisco Javier Tirado Sarti <[email protected]>
@cdavernas cdavernas added this to the v1.0.0 milestone Dec 16, 2024
@cdavernas cdavernas added change: fix Something isn't working. Impacts in a minor version change. area: examples labels Dec 16, 2024
cdavernas added a commit that referenced this issue Dec 16, 2024
[Fix #1040] Set behaviour clarification
@github-project-automation github-project-automation bot moved this from Backlog to Done in Progress Tracker Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: examples change: fix Something isn't working. Impacts in a minor version change.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants