Skip to content

Rename data filter properties #672

Closed
@cdavernas

Description

@cdavernas
Member

What would you like to be added:

To rename data filter properties

Why is this needed:

Having properties such as stateDataFilter when defining a state, or actionDataFilter when defining an action is redudant and tedious to write. So, instead of:

...
states:
- name: MyOperationState
  type: operation
  stateDataFilter: ...
  actions:
    - name: MyAction
      actionDataFilter: ...
      ...
...

... I propose we use:

...
states:
- name: MyOperationState
  type: operation
  dataFilter: ...
  actions:
    - name: MyAction
      dataFilter: ...
      ...
...

IMHO it's less confusing, shorter and cleaner.

Activity

tsurdilo

tsurdilo commented on Sep 9, 2022

@tsurdilo
Contributor

agree but much harder to define cleanly in json schema :) looking into it to see if there is nice way

added
change: featureNew feature or request. Impacts in a minor version change
on Sep 12, 2022
added this to the v0.9 milestone on Sep 12, 2022
github-actions

github-actions commented on Oct 29, 2022

@github-actions

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions

github-actions commented on Dec 15, 2022

@github-actions

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions

github-actions commented on Jan 31, 2023

@github-actions

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

1 remaining item

moved this from Todo to In Progress in Progress Trackeron May 30, 2023
linked a pull request that will close this issueSimplify data filter property names #702on May 30, 2023
self-assigned this
on May 30, 2023
cdavernas

cdavernas commented on May 17, 2024

@cdavernas
MemberAuthor

Closed as resolved by 1.0.0-alpha1, and therefore as part of #843

moved this from In Progress to Done in Progress Trackeron May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area: specChanges in the Specificationchange: featureNew feature or request. Impacts in a minor version change

Type

No type

Projects

Status

Done

Relationships

None yet

    Development

    Participants

    @tsurdilo@ricardozanini@cdavernas

    Issue actions

      Rename data filter properties · Issue #672 · serverlessworkflow/specification