-
Notifications
You must be signed in to change notification settings - Fork 161
Add support for dynamic container names via runtime expressions #1062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cdavernas
merged 4 commits into
serverlessworkflow:main
from
JBBianchi:fix-1056-user-defined-container-name
Jan 10, 2025
Merged
Add support for dynamic container names via runtime expressions #1062
cdavernas
merged 4 commits into
serverlessworkflow:main
from
JBBianchi:fix-1056-user-defined-container-name
Jan 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new optional `name` property in run container tasks, allowing users to define container names dynamically using runtime expressions. - Updated the DSL reference with the new `name` field, detailing its usage and linking to runtime expression documentation. - Added support for the `name` property in the YAML version of the JSON schema. - Included an example demonstrating dynamic container naming based on workflow and task metadata. This enhancement provides improved observability, debugging, and alignment with organizational conventions for container management. Closes serverlessworkflow#1056 Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
cdavernas
reviewed
Jan 10, 2025
cdavernas
reviewed
Jan 10, 2025
cdavernas
requested changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, cheers man ❤️
Signed-off-by: Jean-Baptiste Bianchi <[email protected]> Co-authored-by: Charles d'Avernas <[email protected]>
Signed-off-by: Jean-Baptiste Bianchi <[email protected]> Co-authored-by: Charles d'Avernas <[email protected]>
6936779
to
00cc01b
Compare
ricardozanini
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cdavernas you need to approve it too :p
cdavernas
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: examples
area: spec
Changes in the Specification
change: documentation
Improvements or additions to documentation. It won't impact a version change.
change: feature
New feature or request. Impacts in a minor version change
spec: 1.0.0
type: feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please specify parts of this PR update:
Discussion or Issue link:
#1056
What this PR does:
name
property in run container tasks, allowing users to define container names dynamically using runtime expressions.name
field, detailing its usage and linking to runtime expression documentation.name
property in the YAML version of the JSON schema.This enhancement provides improved observability, debugging, and alignment with organizational conventions for container management.
Additional information: