Skip to content

Add support for dynamic container names via runtime expressions #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

JBBianchi
Copy link
Member

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Use Cases
  • Community
  • CTK
  • Other

Discussion or Issue link:

#1056

What this PR does:

  • Introduced a new optional name property in run container tasks, allowing users to define container names dynamically using runtime expressions.
  • Updated the DSL reference with the new name field, detailing its usage and linking to runtime expression documentation.
  • Added support for the name property in the YAML version of the JSON schema.
  • Included an example demonstrating dynamic container naming based on workflow and task metadata.

This enhancement provides improved observability, debugging, and alignment with organizational conventions for container management.

Additional information:

- Introduced a new optional `name` property in run container tasks, allowing users to define container names dynamically using runtime expressions.
- Updated the DSL reference with the new `name` field, detailing its usage and linking to runtime expression documentation.
- Added support for the `name` property in the YAML version of the JSON schema.
- Included an example demonstrating dynamic container naming based on workflow and task metadata.

This enhancement provides improved observability, debugging, and alignment with organizational conventions for container management.

Closes serverlessworkflow#1056

Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
@JBBianchi JBBianchi self-assigned this Jan 10, 2025
@JBBianchi JBBianchi added change: documentation Improvements or additions to documentation. It won't impact a version change. change: feature New feature or request. Impacts in a minor version change area: spec Changes in the Specification spec: 1.0.0 area: examples type: feature labels Jan 10, 2025
@JBBianchi JBBianchi added this to the v1.0.0 milestone Jan 10, 2025
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cheers man ❤️

JBBianchi and others added 2 commits January 10, 2025 13:08
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Co-authored-by: Charles d'Avernas <[email protected]>
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Co-authored-by: Charles d'Avernas <[email protected]>
@JBBianchi JBBianchi force-pushed the fix-1056-user-defined-container-name branch from 6936779 to 00cc01b Compare January 10, 2025 12:09
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdavernas you need to approve it too :p

@cdavernas cdavernas merged commit e64b3dd into serverlessworkflow:main Jan 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: examples area: spec Changes in the Specification change: documentation Improvements or additions to documentation. It won't impact a version change. change: feature New feature or request. Impacts in a minor version change spec: 1.0.0 type: feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Allow user-defined container names with runtime expressions in run container tasks
3 participants