Update `Set` task to support direct runtime expression #1086

nyamathshaik · 2025-03-09T18:28:05Z

Please specify parts of this PR update:

Discussion or Issue link:

Issue #1087

What this PR does:
This PR updates the Set task:

Modifies the set property Type to include string in addition to object.
Updates the Description to clarify that set can be an object or a direct runtime expression.
Adds a new Example demonstrating direct runtime expressions.

Additional information:

This change makes it easier to set values dynamically in workflows without requiring an object structure.

cdavernas · 2025-03-09T18:31:23Z

@nyamathshaik Thanks!
Can I ask you to please open an issue that describes what your PR addresses?

dsl-reference.md

schema/workflow.yaml

examples/set.yaml

dsl-reference.md

examples/set-expression.yaml

examples/set.yaml

dsl-reference.md

examples/set.yaml

cdavernas · 2025-03-10T13:58:10Z

@nyamathshaik DCO is failing. Can you please sign-off?

cdavernas

LGTM! Cheers ❤️

examples/set.yaml

…ion in the schema Signed-off-by: Ricardo Zanini <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]>

Signed-off-by: Ricardo Zanini <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]>

…workflow#1080) Issue serverlessworkflow#1079 Signed-off-by: Alexandru Georoceanu <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]>

serverlessworkflow#1082) * update DSL version from alpha1, alpha2, alpha5 to 1.0.0 across multiple YAML files Signed-off-by: Gilles Barbier <[email protected]> * fix(contributing): reverting pre-release versioning format Signed-off-by: Gilles Barbier <[email protected]> --------- Signed-off-by: Gilles Barbier <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]>

…l and dsl-reference (serverlessworkflow#1083) * update DSL version from alpha1, alpha2, alpha5 to 1.0.0 across multip… (serverlessworkflow#1082) * update DSL version from alpha1, alpha2, alpha5 to 1.0.0 across multiple YAML files Signed-off-by: Gilles Barbier <[email protected]> * fix(contributing): reverting pre-release versioning format Signed-off-by: Gilles Barbier <[email protected]> --------- Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl): fix a few issues in dsl and dsl-reference Signed-off-by: Gilles Barbier <[email protected]> * update .gitignore to include .DS_Store Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): correct table formatting Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): clarify flow directive descriptions Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): improve table formatting Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): clarify flow directive descriptions Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl): fix a few issues in dsl and dsl-reference Signed-off-by: Gilles Barbier <[email protected]> * update .gitignore to include .DS_Store Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): correct table formatting Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): clarify flow directive descriptions Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): improve table formatting Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): clarify flow directive descriptions Signed-off-by: Gilles Barbier <[email protected]> * fix(dsl-reference): improve table formatting Signed-off-by: Gilles Barbier <[email protected]> * remove again .DS_Store Signed-off-by: Gilles Barbier <[email protected]> --------- Signed-off-by: Gilles Barbier <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]>

Signed-off-by: Michal Broz <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]>

Signed-off-by: Nyamath Shaik <[email protected]>

Co-authored-by: Charles d'Avernas <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]>

Signed-off-by: Nyamath Shaik <[email protected]>

Co-authored-by: Charles d'Avernas <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]>

Signed-off-by: Nyamath Shaik <[email protected]>

… DSLs Signed-off-by: Charles d'Avernas <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]>

…ow#1088) Signed-off-by: Charles d'Avernas <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]>

nyamathshaik · 2025-03-19T07:03:03Z

@ricardozanini Can you please help approve and merge this PR?

nyamathshaik requested review from ricardozanini and cdavernas as code owners March 9, 2025 18:28

nyamathshaik force-pushed the feat/set-task-support-direct-runtime-expression branch from 00ea11b to 0b67120 Compare March 9, 2025 18:30

cdavernas changed the title ~~feat: Set-task to support direct runtime expression~~ Update Set task to support direct runtime expression Mar 9, 2025

cdavernas requested changes Mar 9, 2025

View reviewed changes

dsl-reference.md Outdated Show resolved Hide resolved

cdavernas linked an issue Mar 9, 2025 that may be closed by this pull request

Enhance Set Task to Support Direct Runtime Expressions #1087

Closed

nyamathshaik force-pushed the feat/set-task-support-direct-runtime-expression branch from aeb5fb5 to 93fd28d Compare March 9, 2025 18:59

nyamathshaik requested a review from cdavernas March 9, 2025 19:00

nyamathshaik force-pushed the feat/set-task-support-direct-runtime-expression branch from 53f3f5b to f2f6ec3 Compare March 9, 2025 19:07

cdavernas requested changes Mar 10, 2025

View reviewed changes

schema/workflow.yaml Outdated Show resolved Hide resolved

examples/set.yaml Show resolved Hide resolved

dsl-reference.md Outdated Show resolved Hide resolved

nyamathshaik force-pushed the feat/set-task-support-direct-runtime-expression branch from 99f3afd to 9ba4c3f Compare March 10, 2025 10:49

nyamathshaik requested a review from cdavernas March 10, 2025 10:50

cdavernas requested changes Mar 10, 2025

View reviewed changes

nyamathshaik force-pushed the feat/set-task-support-direct-runtime-expression branch 3 times, most recently from 889ef24 to 768960f Compare March 10, 2025 11:28

nyamathshaik requested a review from cdavernas March 10, 2025 11:37

cdavernas requested changes Mar 10, 2025

View reviewed changes

dsl-reference.md Outdated Show resolved Hide resolved

examples/set.yaml Show resolved Hide resolved

nyamathshaik force-pushed the feat/set-task-support-direct-runtime-expression branch from 8dc53bb to 71b7598 Compare March 10, 2025 12:10

nyamathshaik requested a review from cdavernas March 10, 2025 12:10

cdavernas requested changes Mar 10, 2025

View reviewed changes

examples/set.yaml Show resolved Hide resolved

nyamathshaik force-pushed the feat/set-task-support-direct-runtime-expression branch from 3240fd0 to 0e5d0a4 Compare March 10, 2025 12:20

nyamathshaik requested a review from cdavernas March 10, 2025 12:21

cdavernas approved these changes Mar 10, 2025

View reviewed changes

nyamathshaik force-pushed the feat/set-task-support-direct-runtime-expression branch 2 times, most recently from d596b72 to 3a695ae Compare March 10, 2025 14:04

ricardozanini reviewed Mar 10, 2025

View reviewed changes

examples/set.yaml Outdated Show resolved Hide resolved

Fix serverlessworkflow#1076 - Make detail and title a runtime express…

6e99bae

…ion in the schema Signed-off-by: Ricardo Zanini <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]>

ricardozanini and others added 19 commits March 19, 2025 12:32

Add string as anyOf

947c368

Signed-off-by: Ricardo Zanini <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]>

feat(schema): allow expressions in HTTP query and headers (serverless…

a035fee

…workflow#1080) Issue serverlessworkflow#1079 Signed-off-by: Alexandru Georoceanu <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]>

Fix broken link in README.md (serverlessworkflow#1084)

f2d0501

Signed-off-by: Michal Broz <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]>

Set task to support direct runtime expression

d73165a

Signed-off-by: Nyamath Shaik <[email protected]>

updated workflow schema along with table fix

cfc7e75

Signed-off-by: Nyamath Shaik <[email protected]>

updating the schema

dbc4529

Signed-off-by: Nyamath Shaik <[email protected]>

addressing PR comment reviews

86fc361

Signed-off-by: Nyamath Shaik <[email protected]>

removing unwanted set example

3a05358

Signed-off-by: Nyamath Shaik <[email protected]>

Update dsl-reference.md

7a0e4aa

Co-authored-by: Charles d'Avernas <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]>

Update dsl-reference.md

83778e5

Co-authored-by: Charles d'Avernas <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]>

Update dsl-reference.md

7c05b93

Co-authored-by: Charles d'Avernas <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]>

reverting back original set example change

052c34f

Signed-off-by: Nyamath Shaik <[email protected]>

Update dsl-reference.md

33ec5e1

Co-authored-by: Charles d'Avernas <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]>

passing the set example as object

d25ca39

Signed-off-by: Nyamath Shaik <[email protected]>

reverting to original

5f69853

Signed-off-by: Nyamath Shaik <[email protected]>

Add a new file that compares the Serverless Workflow to other popular…

25a7d30

… DSLs Signed-off-by: Charles d'Avernas <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]>

Fix a the catalog link in the use section table (serverlessworkfl…

3951cd0

…ow#1088) Signed-off-by: Charles d'Avernas <[email protected]> Signed-off-by: Nyamath Shaik <[email protected]>

nyamathshaik force-pushed the feat/set-task-support-direct-runtime-expression branch from ed5d02f to 3951cd0 Compare March 19, 2025 07:02

Merge branch 'main' into feat/set-task-support-direct-runtime-expression

6b85537

ricardozanini approved these changes Mar 19, 2025

View reviewed changes

ricardozanini merged commit 0ceb0e3 into serverlessworkflow:main Mar 19, 2025
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update `Set` task to support direct runtime expression #1086

Update `Set` task to support direct runtime expression #1086

Uh oh!

nyamathshaik commented Mar 9, 2025 •

edited

Loading

Uh oh!

cdavernas commented Mar 9, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cdavernas commented Mar 10, 2025

Uh oh!

cdavernas left a comment

Uh oh!

Uh oh!

nyamathshaik commented Mar 19, 2025

Uh oh!

Uh oh!

Uh oh!

Update Set task to support direct runtime expression #1086

Update Set task to support direct runtime expression #1086

Uh oh!

Conversation

nyamathshaik commented Mar 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cdavernas commented Mar 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cdavernas commented Mar 10, 2025

Uh oh!

cdavernas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nyamathshaik commented Mar 19, 2025

Uh oh!

Uh oh!

Uh oh!

Update `Set` task to support direct runtime expression #1086

Update `Set` task to support direct runtime expression #1086

nyamathshaik commented Mar 9, 2025 •

edited

Loading

cdavernas commented Mar 9, 2025 •

edited

Loading