Skip to content

Conversation

lsytj0413
Copy link
Contributor

Signed-off-by: lsytj0413 [email protected]

Many thanks for submitting your Pull Request ❤️!

Please specify parts of this PR update:

  • Other

Discussion or Issue link:

What this PR does / why we need it:

  • According to the examples, the Auth field't type should be array or object, not array or string

Special notes for reviewers:

Additional information:

Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lsytj0413 No, the top level auth property should indeed be of array or string types, I don't know which examples you are speaking about, which would be where the error(s) is/are.

In the case auth is string, it is considered as a reference to an external definition of the array (ex: https://test.com/mysharedauth)

@ricardozanini
Copy link
Member

@lsytj0413, @cdavernas is right. The string, in this case, is an external reference. Can you please point out the examples you saw the error?

@ricardozanini ricardozanini self-requested a review September 6, 2022 19:21
@lsytj0413 lsytj0413 changed the title fix(*): update auth struct type to arrya or object fix(*): update auth struct type to array or object Sep 7, 2022
@lsytj0413
Copy link
Contributor Author

lsytj0413 commented Sep 7, 2022

@lsytj0413 No, the top level auth property should indeed be of array or string types, I don't know which examples you are speaking about, which would be where the error(s) is/are.

In the case auth is string, it is considered as a reference to an external definition of the array (ex: https://test.com/mysharedauth)

I have seen this example in sdk-go implement and it should validate with no error.

So, this should be an bug in sdk-go?

@tsurdilo
Copy link
Contributor

tsurdilo commented Sep 7, 2022

I have seen this example in sdk-go implement and it should validate with no error.

nice catch, i think the sample in go sdk should be updated

@tsurdilo tsurdilo added the change: documentation Improvements or additions to documentation. It won't impact a version change. label Sep 7, 2022
@tsurdilo tsurdilo added this to the v0.9 milestone Sep 7, 2022
@lsytj0413
Copy link
Contributor Author

lsytj0413 commented Sep 7, 2022

Ok,If we confirm it's a bug in sdk-go,i would like to fix it.

@ricardozanini
Copy link
Member

The SDK is implementing version 0.7 of the spec. Thanks for the PR; I've pushed it to the 0.8 milestone! :)

@lsytj0413 lsytj0413 deleted the fix-auth-struct-type branch September 9, 2022 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change: documentation Improvements or additions to documentation. It won't impact a version change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants