-
Notifications
You must be signed in to change notification settings - Fork 166
Add Schema Validation and Examples to CI #801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the TS, I think it's small enough not to bother too much. Just for informative purposes, I created a fork to use async/await, it might be better than using blocking apis and more "readable" or "accessible" to some, but not very important.
For the rest, LGTM ! Great work as usual @ricardozanini ! ❤️
@JBBianchi So I can expect a PR soon coming here upgrading this code base + post-hook/templating README? :D |
Yes, with pleasure, I'll do as soon as than one is merged. |
@cdavernas can you take a look? I'll open a second PR to actually solve #794. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't check it all, but I had a good overview and looks great to me!
Thanks for your awesome work @ricardozanini !
Has been two weeks since the introduction of this PR and we have two votes for merging. I think we can go ahead @cdavernas |
@ricardozanini Agreed, as per code of conduct. |
from serverlessworkflow/specification#801 Signed-off-by: Gloria Ciavarrini <[email protected]>
Many thanks for submitting your Pull Request ❤️!
Please specify parts of this PR update:
Discussion or Issue link:
#794
What this PR does / why we need it:
Open a new PR:
properties
field to each separate definition so we enable single validation. For example,functions.json
should be able to serve as a single schema definition.Special notes for reviewers:
@JBBianchi After merging this one, we can then add the git post-hook to have an updated README file.
Additional information:
Now we have an application to maintain :)
I'm not a Node.js/Typescript specialist, so if there's something to improve, please let me know in the review.