Skip to content

Conversation

matthias-pichler
Copy link
Collaborator

Signed-off-by: Matthias Pichler [email protected]

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Use Cases
  • Community
  • CTK
  • Other

Discussion or Issue link:

What this PR does:

The DSL describes the callHttp endpoint property as:

An URI or an object that describes the HTTP endpoint to call.

However:

  1. many examples used a uri field directly in call http tasks
  2. the schema did not allow to specify a string directly

so I fixed both

Additional information:

@matthias-pichler matthias-pichler force-pushed the fix-usage-of-endpoint-in-call-http branch from 3249ba3 to a07afc0 Compare June 3, 2024 13:33
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Cheers!

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be a PITA, but can you add an example? I think ours only has this structure:

endpoint:
    uri: ...

@matthias-pichler
Copy link
Collaborator Author

Sorry to be a PITA, but can you add an example? I think ours only has this structure:

endpoint:
    uri: ...

Sorry to be a PITA, but can you add an example? I think ours only has this structure:

endpoint:
    uri: ...

no worries ... added an example 👍

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in this case the format is uri-template since we want to support dynamic calls within the task.

Signed-off-by: Matthias Pichler <[email protected]>
@ricardozanini ricardozanini merged commit a25f33c into serverlessworkflow:main Jun 3, 2024
@matthias-pichler matthias-pichler deleted the fix-usage-of-endpoint-in-call-http branch June 3, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants