Preserve endpoint field by converting JSON to YAML in create/edit view of the Dashboard #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… create/edit view Closes #534 Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
JBBianchi
added
type: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
The create/edit workflow view was serializing the definition directly to YAML, which caused endpoint fields to be replaced with
{}in the editor.This PR aligns the behavior with the details view by always serializing to JSON first and converting to YAML only if the editor is configured for it.
This ensures endpoint fields are correctly preserved when editing workflows in the UI.
Closes #534
Special notes for reviewers:
Additional information (if needed):