Skip to content

Implement a builder API for font variations #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tracked by #719
jdm opened this issue Feb 26, 2018 · 0 comments
Open
Tracked by #719

Implement a builder API for font variations #201

jdm opened this issue Feb 26, 2018 · 0 comments

Comments

@jdm
Copy link
Member

jdm commented Feb 26, 2018

Rather than having consumers pass in a stringly-typed dictionary for new_from_variations, it would be nice to provide a strong builder API that encapsulates that process.

bors-servo pushed a commit that referenced this issue May 2, 2018
Only allow CFNumber font variations.

Until #201 this seems like a worthwhile improvement.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/202)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue May 2, 2018
Only allow CFNumber font variations.

Until #201 this seems like a worthwhile improvement.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/202)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant