-
Notifications
You must be signed in to change notification settings - Fork 232
Remove zero-sized struct warning. #106. #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jdm fyi. |
Want to increase the version number in Cargo.toml as well so we can publish after merging the changes? |
Ack, will do for |
I've bumped the version number. |
@bors-servo: r+ |
📌 Commit 4c83733 has been approved by |
Remove zero-sized struct warning. #106. This change will fix the remaining warnings in servo/core-text-rs#62 when it is released and the core-text crate is updated. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/107) <!-- Reviewable:end -->
💔 Test failed - status-travis |
Want to fix this too? |
Yep, will take a look. |
E0133 has gone from warning to error on nightly now, this fix allows the tests to pass on nightly.
@bors-servo: r+ |
📌 Commit a37ecf5 has been approved by |
Remove zero-sized struct warning. #106. This change will fix the remaining warnings in servo/core-text-rs#62 when it is released and the core-text crate is updated. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/107) <!-- Reviewable:end -->
Pushed a commit to the PR that fixes this - as it was in the tests I figured wrapping the invocation in |
☀️ Test successful - status-travis |
Bump version to 0.12.2 This includes CGFont::create_copy_from_variations. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-graphics-rs/107) <!-- Reviewable:end -->
This change will fix the remaining warnings in servo/core-text-rs#62 when it is released and the core-text crate is updated.
This change is