Skip to content

Conversation

bryanburgers
Copy link
Contributor

Add a name method to CFTimeZone to get the time zone ID (e.g.,
"America/Los_Angeles") of the current time zone.

Core Foundation calls this "name" instead of "id" in its method
signatures, but acknowledges it in the closely-related NSTimeZone
related docs. Since most of the other methods in this library match
closely with CF naming, also use name here.

Time zone database entries such as “America/Los_Angeles” are IDs, not
names. An example of a time zone name is “Pacific Daylight Time”.
Although many NSTimeZone symbols include the word “name”, they
actually refer to IDs.

Add a `name` method to `CFTimeZone` to get the time zone ID (e.g.,
"America/Los_Angeles") of the current time zone.

Core Foundation calls this "name" instead of "id" in its method
signatures, but acknowledges it in the closely-related NSTimeZone
related docs. Since most of the other methods in this library match
closely with CF naming, also use `name` here.

> Time zone database entries such as “America/Los_Angeles” are IDs, not
> names. An example of a time zone name is “Pacific Daylight Time”.
> Although many NSTimeZone symbols include the word “name”, they
> actually refer to IDs.
@jdm
Copy link
Member

jdm commented Jun 29, 2020

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit a4e2983 has been approved by jdm

@bors-servo
Copy link
Contributor

⌛ Testing commit a4e2983 with merge 3754007...

@bors-servo
Copy link
Contributor

☀️ Test successful - checks-travis
Approved by: jdm
Pushing 3754007 to master...

@bors-servo bors-servo merged commit 3754007 into servo:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants