Add a test for variation preservation. #439
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrmuizel
force-pushed
the
broken-variations
branch
4 times, most recently
from
376b536 to
0488869
Compare
jrmuizel
force-pushed
the
broken-variations
branch
from
0488869 to
3f936a2
Compare
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 10, 2021
This is an alternate approach to aadbc6deca05. CTFontCreateWithGraphicsFont seems to give "LastResort" when used on a system CGFont with variation applied on 10.12-10.14. We can avoid that by using CTFontCreateWithGraphicsFont with a variation descriptor. I'm only applying this approach to cairo for now to mimimize the risk of this breaking something or causing the crashes that we were seeing before. See servo/core-foundation-rs#439 for a standalone test case. Differential Revision: https://phabricator.services.mozilla.com/D104581
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 10, 2021
This is an alternate approach to aadbc6deca05. CTFontCreateWithGraphicsFont seems to give "LastResort" when used on a system CGFont with variation applied on 10.12-10.14. We can avoid that by using CTFontCreateWithGraphicsFont with a variation descriptor. I'm only applying this approach to cairo for now to mimimize the risk of this breaking something or causing the crashes that we were seeing before. See servo/core-foundation-rs#439 for a standalone test case. Differential Revision: https://phabricator.services.mozilla.com/D104581
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Feb 11, 2021
This is an alternate approach to aadbc6deca05. CTFontCreateWithGraphicsFont seems to give "LastResort" when used on a system CGFont with variation applied on 10.12-10.14. We can avoid that by using CTFontCreateWithGraphicsFont with a variation descriptor. I'm only applying this approach to cairo for now to mimimize the risk of this breaking something or causing the crashes that we were seeing before. See servo/core-foundation-rs#439 for a standalone test case. Differential Revision: https://phabricator.services.mozilla.com/D104581
|
☔ The latest upstream changes (presumably #485) made this pull request unmergeable. Please resolve the merge conflicts. |
bhearsum
pushed a commit
to mozilla-releng/staging-firefox
that referenced
this pull request
May 1, 2025
This is an alternate approach to aadbc6deca05. CTFontCreateWithGraphicsFont seems to give "LastResort" when used on a system CGFont with variation applied on 10.12-10.14. We can avoid that by using CTFontCreateWithGraphicsFont with a variation descriptor. I'm only applying this approach to cairo for now to mimimize the risk of this breaking something or causing the crashes that we were seeing before. See servo/core-foundation-rs#439 for a standalone test case. Differential Revision: https://phabricator.services.mozilla.com/D104581
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.