transform3d: Introduce Transform3D::project_to_2d to flatten a transform #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orm. Need to use this for servo/webrender#3394. The normalization of perspective is not necessary but Gecko does it as a performance optimization, and ScaleOffset in WR wouldn't handle this. See: https://bugzilla.mozilla.org/show_bug.cgi?id=1241161 But in any case I'm happy to teach ScaleOffset about that case instead if you think it's better.
emilio
force-pushed
the
flatten-transform
branch
from
ac42b16 to
aa0ed0c
Compare
kvark
approved these changes
Dec 7, 2018
|
Might need a patch version bump as well 👍 |
|
Good point. @bors-servo r=kvark |
|
📌 Commit 1c62063 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Dec 7, 2018
transform3d: Introduce Transform3D::project_to_2d to flatten a transform Need to use this for servo/webrender#3394. The normalization of perspective is not necessary but Gecko does it as a performance optimization, and ScaleOffset in WR wouldn't handle this. See: https://bugzilla.mozilla.org/show_bug.cgi?id=1241161 But in any case I'm happy to teach ScaleOffset about that case instead if you think it's better. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/310) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to use this for servo/webrender#3394.
The normalization of perspective is not necessary but Gecko does it as a
performance optimization, and ScaleOffset in WR wouldn't handle this.
See: https://bugzilla.mozilla.org/show_bug.cgi?id=1241161
But in any case I'm happy to teach ScaleOffset about that case instead if you
think it's better.
This change is