This repository was archived by the owner on Jul 10, 2023. It is now read-only.
Remove implementations for Arc and Vec<Rc> #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is better to have no measurements rather than blatantly incorrect ones.
|
r=me with a semver-breaking version number change. CC #37 |
|
I figured it would be rolled in with the number change in #84. |
|
Ok, I’m fine with landing this as long as we don’t forget. CI is still failing with #86, though. |
|
Sounds like #84 is not happening, and I don’t feel like going through all reverse dependencies to increment the version number just for this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is better to have no measurements rather than blatantly incorrect ones.
This change is