Remove time dependency #453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
time 0.1 has known security issues, and it's not really necessary to use time crate anymore for getting precise instants as std::time::Instant::now has the same implementation as precise_time_ns on popular platforms [1]. [1]: https://stackoverflow.com/a/55619763
|
@bors-servo r+ |
|
📌 Commit b2b8030 has been approved by |
bors-servo
added a commit
that referenced
this pull request
Oct 19, 2021
Remove time dependency time 0.1 has known security issues, and it's not really necessary to use time crate anymore for getting precise instants as std::time::Instant::now [has the same implementation as precise_time_ns on popular platforms](https://stackoverflow.com/a/55619763).
|
💔 Test failed - checks-github |
|
Test appears to fail because of |
rnestler
added a commit
to rnestler/attractorr
that referenced
this pull request
Oct 24, 2021
xml5ever only uses `time::precise_time_ns` which is not affected according to https://rustsec.org/advisories/RUSTSEC-2020-0071. Also there is a pull request open which will remove the time dependency completely: servo/html5ever#453
rnestler
added a commit
to rnestler/attractorr
that referenced
this pull request
Oct 24, 2021
xml5ever only uses `time::precise_time_ns` which is not affected according to https://rustsec.org/advisories/RUSTSEC-2020-0071. Also there is a pull request open which will remove the time dependency completely: servo/html5ever#453
|
Addressing the criterion issue in #457. @bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Nov 21, 2021
Remove time dependency time 0.1 has known security issues, and it's not really necessary to use time crate anymore for getting precise instants as std::time::Instant::now [has the same implementation as precise_time_ns on popular platforms](https://stackoverflow.com/a/55619763).
|
💔 Test failed - checks-github |
|
@bors-servo retry |
|
☀️ Test successful - checks-github |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
time 0.1 has known security issues, and it's not really necessary to use time crate anymore for getting precise instants as std::time::Instant::now has the same implementation as precise_time_ns on popular platforms.