chore: rust edition 2021 and clippy #456
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian-Schoenherr <[email protected]>
| } | ||
|
|
||
| /// A subset/refinement of `tokenizer::XToken`. Everything else is handled | ||
| /// specially at the beginning of `process_token`. | ||
| #[derive(PartialEq, Eq, Clone, Debug)] | ||
| pub enum Token { | ||
| pub enum TokenWrapper { |
There was a problem hiding this comment.
clippy complained, I think Wrapper makes sense, as XTokens get wrapped by it.
pub so might need version bump
| @@ -16,15 +16,15 @@ use crate::tokenizer::{Doctype, Pi, Tag}; | |||
|
|
|||
| #[derive(PartialEq, Eq, Copy, Clone, Debug)] | |||
| pub enum XmlPhase { | |||
There was a problem hiding this comment.
clippy complained, I think removing Phase makes sense.
pub so might need version bump
| @@ -105,13 +102,13 @@ impl BufferQueue { | |||
| /// Get the next character if one is available, removing it from the queue. | |||
| /// | |||
| /// This function manages the buffers, removing them as they become empty. | |||
| pub fn next(&mut self) -> Option<char> { | |||
| pub fn next_char(&mut self) -> Option<char> { | |||
There was a problem hiding this comment.
clippy complained, thinks it could be confused with std::iter::Iterator::next,
also pub so if we need a version bump anyways, we could update this as well,
or we can revert
|
☔ The latest upstream changes (presumably #457) made this pull request unmergeable. Please resolve the merge conflicts. |
|
yeah whatever I can't get rustfmt to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a lot, but small changes, see review below for some discussion