Don't import enum variants into the global namespace in html5ever #593
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the tokenizer and treebuilder in html5ever import all variants of commonly used enums:
This is not really idiomatic rust. I've never seen any other codebase do this, and it is not the style we use in servo either.
This change removes the imports and instead uses the
Token::Foo
notation, renaming the variants where appropriate.This is a breaking change, because the
PushFlag
import was public (even though it really shouldn't have been, I suspect that's another common problem in html5ever).