unix: Check libc not os, and zero msghdr private #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @emilio (or someone else) soon. |
|
|
dlrobertson
reviewed
Jan 7, 2019
src/platform/unix/mod.rs
Outdated
| msghdr.msg_iovlen = iovec.len() as IovLen; | ||
| msghdr.msg_control = cmsg_buffer as *mut c_void; | ||
| msghdr.msg_controllen = cmsg_space as MsgControlLen; | ||
| msghdr.msg_flags = 0; |
There was a problem hiding this comment.
Could you wrap this into a function? E.g. new_msghdr?
There was a problem hiding this comment.
Sorry for the noise, I seem to misunderstand how to extract this piece. Will get back to this.
dlrobertson
reviewed
Jan 7, 2019
src/platform/unix/mod.rs
Outdated
| msg_controllen: cmsg_length as MsgControlLen, | ||
| msg_flags: 0, | ||
| }, | ||
| msghdr: new_msghdr(&mut iovec, cmsg_buffer, cmsg_length as MsgControlLen) |
There was a problem hiding this comment.
iovec is already an &mut [iovec] no need for the &mut.
Fixes #192. Now builds on musl.
|
@bors-servo r+ |
|
📌 Commit cee64a7 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jan 9, 2019
unix: Check libc not os, and zero msghdr private Fixes #192 similarly to what [audioipc-2](https://github.com/djg/audioipc-2/blob/1033cf7e4b5d14a138004bbb8708b2a1c3821939/audioipc/src/msg.rs#L79) does. Now builds on musl.
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #192 similarly to what audioipc-2 does. Now builds on musl.