Avoid overflowing the stack in consume_until_end_of_block. #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nox
reviewed
Dec 15, 2016
| // FIXME: have a special-purpose tokenizer method for this that does less work. | ||
| while let Ok(ref token) = tokenizer.next() { | ||
| if BlockType::closing(token) == Some(block_type) { | ||
| return | ||
| if let Some(b) = BlockType::closing(token){ |
|
Done
…On Thu, Dec 15, 2016 at 06:03:48AM -0800, Anthony Ramine wrote:
nox commented on this pull request.
> // FIXME: have a special-purpose tokenizer method for this that does less work.
while let Ok(ref token) = tokenizer.next() {
- if BlockType::closing(token) == Some(block_type) {
- return
+ if let Some(b) = BlockType::closing(token){
Space before brace.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#111 (review)
|
|
r=me with a semver-compatible version bump. |
|
@bors-servo r=SimonSapin |
|
📌 Commit 071323a has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Dec 15, 2016
Avoid overflowing the stack in consume_until_end_of_block. Fixes: https://bugzilla.mozilla.org/show_bug.cgi?id=1323705 r? @SimonSapin <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/111) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://bugzilla.mozilla.org/show_bug.cgi?id=1323705
r? @SimonSapin
This change is