Numeric faster #132
Merged
Numeric faster #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdm
reviewed
Apr 7, 2017
src/tokenizer.rs
Outdated
| Some(match_byte! { b, | ||
| b'0' ... b'9' => { b - b'0' }, | ||
| b'a' ... b'z' => { b - b'a' + 10 }, | ||
| b'A' ... b'Z' => { b - b'A' }, |
There was a problem hiding this comment.
This is an unusual definition of hexadecimal.
The following commit: * Removes char logic from consume_numeric. * Rearranges exponent parsing to look at one char in the common case (presumably not a big deal). This makes the benchmark added in the first commit go from: test tests::numeric ... bench: 48,221,308 ns/iter (+/- 3,356,881) to: test tests::numeric ... bench: 43,656,802 ns/iter (+/- 1,323,570) on my machine. Which is pretty much a micro-optimization, but perhaps it's worth given how common these values are.
|
@bors-servo r+ |
|
📌 Commit 2b6cc13 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Apr 9, 2017
Numeric faster The following commit: * Removes char logic from consume_numeric. * Rearranges exponent parsing to look at one char in the common case (presumably not a big deal). This makes the benchmark added in the first commit go from: test tests::numeric ... bench: 48,221,308 ns/iter (+/- 3,356,881) to: test tests::numeric ... bench: 43,656,802 ns/iter (+/- 1,323,570) on my machine. Which is pretty much a micro-optimization, but perhaps it's worth given how common these values are. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/132) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following commit:
(presumably not a big deal).
This makes the benchmark added in the first commit go from:
test tests::numeric ... bench: 48,221,308 ns/iter (+/- 3,356,881)
to:
test tests::numeric ... bench: 43,656,802 ns/iter (+/- 1,323,570)
on my machine.
Which is pretty much a micro-optimization, but perhaps it's worth given how
common these values are.
This change is